Add attributes used in input[type=range] #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks fine, if you can just put them in alphabetical order with the rest of the DOM properties I can merge. |
|
Thanks @camspiers ! This is ready to go in. I actually want to wait until @zpao is around to merge (he's the one who is working on our internal<->github stuff). src/ gets synced back and forth from our internal repo, so I don't want your pull to go in here and then somehow get overwritten when the sync happens (that way you keep attribution). @zpao knows how this works though. Thanks! |
|
Sounds good :) |
|
We're still working out the kinks but let's just merge this in and figure out the rest later. We'll never overwrite history in this repo so there will always be record of it :) Thanks Cam! |
zpao
added a commit
that referenced
this pull request
Jun 3, 2013
Add attributes used in input[type=range]
bvaughn
added a commit
to bvaughn/react
that referenced
this pull request
Aug 13, 2019
Fix casing on store import
taneliang
referenced
this pull request
in MLH-Fellowship/react
Aug 17, 2020
Test Plan === 1. `yarn lint` 1. `yarn flow`: Speedscope no longer has any errors (Flow type generation fixed in updated Speedscope fork). Works towards #38 1. `yarn test` 1. `yarn start`
taneliang
referenced
this pull request
in MLH-Fellowship/react
Aug 17, 2020
Summary === 1. Fix some errors manually 1. Copy some updated ContextMenu code from original React sources Resolves #38. Test Plan === 1. `yarn flow`: No errors 1. `yarn lint` 1. `yarn test` 1. `yarn start`: Everything still works, especially the context menu.
taneliang
referenced
this pull request
in MLH-Fellowship/react
Aug 17, 2020
Test Plan === 1. `yarn lint` 1. `yarn flow`: Speedscope no longer has any errors (Flow type generation fixed in updated Speedscope fork). Works towards #38 1. `yarn test` 1. `yarn start`
taneliang
referenced
this pull request
in MLH-Fellowship/react
Aug 17, 2020
Summary === 1. Fix some errors manually 1. Copy some updated ContextMenu code from original React sources Resolves #38. Test Plan === 1. `yarn flow`: No errors 1. `yarn lint` 1. `yarn test` 1. `yarn start`: Everything still works, especially the context menu.
taneliang
referenced
this pull request
in MLH-Fellowship/react
Aug 19, 2020
Test Plan === 1. `yarn lint` 1. `yarn flow`: Speedscope no longer has any errors (Flow type generation fixed in updated Speedscope fork). Works towards #38 1. `yarn test` 1. `yarn start`
taneliang
referenced
this pull request
in MLH-Fellowship/react
Aug 19, 2020
Summary === 1. Fix some errors manually 1. Copy some updated ContextMenu code from original React sources Resolves #38. Test Plan === 1. `yarn flow`: No errors 1. `yarn lint` 1. `yarn test` 1. `yarn start`: Everything still works, especially the context menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for:
I have completed the CLA.